From 63a8436f118065237ba4d680f848bce68505fbd0 Mon Sep 17 00:00:00 2001
From: Antonio De Lucreziis <antonio.delucreziis@gmail.com>
Date: Thu, 16 Feb 2023 13:10:43 +0100
Subject: [PATCH] some fixes

---
 bin/pdfcompress2 | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/bin/pdfcompress2 b/bin/pdfcompress2
index fd59b5f..a9ca1d3 100755
--- a/bin/pdfcompress2
+++ b/bin/pdfcompress2
@@ -5,12 +5,11 @@ set -euo pipefail
 help_message="$(cat <<END
 usage: $(basename "$0") [OPTIONS...] INPUT_PDF OUTPUT_PDF
 
-Converts a PDF file to a series of JPEG images using convert to reduce the quality 
-and then merges back the result in a single pdf 
+Converts a PDF file to a series of JPEG images to reduce the quality 
+and then merges them back in a single pdf. 
 
 Options:
     -q, --quality    Set the JPEG quality (default: 75)
-    -v, --verbose    Enable verbose output, also shows an estimate of remaining time
     -h, --help       Display this help message
 
 END
@@ -22,7 +21,6 @@ function show_usage() {
 }
 
 quality=75
-verbose=false
 
 while [[ $# -gt 0 ]]
 do
@@ -34,10 +32,6 @@ do
             shift # past argument
             shift # past value
             ;;
-        -v|--verbose)
-            verbose=true
-            shift # past argument
-            ;;
         -h|--help)
             show_usage
             ;;
@@ -61,21 +55,19 @@ output_file="$2"
 temp_pages_dir="$(mktemp -d)"
 
 function logf {
-    if [ "$verbose" = true ]; then
-        printf "$@"
-    fi
+    printf "$@"
 }
 
-logf "Rendering each page to a jpeg image (quality = $quality%)\n"
+logf "Rendering each page to a jpeg image (quality = $quality)\n"
 pdftoppm -r 300 -jpeg -jpegopt "quality=$quality,optimize=y" -progress $input_file "$temp_pages_dir/page"
 
-for f in *.jpg; do
-    log "Wrapping $f into ${f/.jpg/.pdf}\n"
+for f in "$temp_pages_dir"/page-*.jpg; do
+    logf "Wrapping $f into ${f/.jpg/.pdf}\n"
     gs -dNOSAFER  -sDEVICE=pdfwrite -o "${f/.jpg/.pdf}" /usr/share/ghostscript/lib/viewjpeg.ps -c "($f)" viewJPEG
 done
 
 logf "Merging compressed pages to a single PDF ()\n"
-pdfunite "$temp_pages_dir"/page*.pdf $output_file
+pdfunite "$temp_pages_dir"/page-*.pdf $output_file
 
 rm -r "$temp_pages_dir"
 logf "Done\n"