From dedb5d529a5f3e4bfe0f9cbd015148083494a39f Mon Sep 17 00:00:00 2001 From: David Rennalls Date: Wed, 24 Feb 2016 19:20:26 -0500 Subject: [PATCH] do_execute not sending error response on failure nbconvert --execute will not not detect a cell execution failure unless an error response is sent --- bash_kernel/kernel.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/bash_kernel/kernel.py b/bash_kernel/kernel.py index ca826fc..84be905 100644 --- a/bash_kernel/kernel.py +++ b/bash_kernel/kernel.py @@ -103,8 +103,12 @@ class BashKernel(Kernel): exitcode = 1 if exitcode: - return {'status': 'error', 'execution_count': self.execution_count, - 'ename': '', 'evalue': str(exitcode), 'traceback': []} + error_content = {'execution_count': self.execution_count, + 'ename': '', 'evalue': str(exitcode), 'traceback': []} + + self.send_response(self.iopub_socket, 'error', error_content) + error_content['status'] = 'error' + return error_content else: return {'status': 'ok', 'execution_count': self.execution_count, 'payload': [], 'user_expressions': {}} @@ -138,7 +142,7 @@ class BashKernel(Kernel): cmd = 'compgen -cdfa %s' % token output = self.bashwrapper.run_command(cmd).rstrip() matches.extend(output.split()) - + if not matches: return default matches = [m for m in matches if m.startswith(token)]