From ffd3c99292197f85d549806a3253d3794edd46f7 Mon Sep 17 00:00:00 2001
From: Antonio De Lucreziis <antonio.delucreziis@gmail.com>
Date: Thu, 17 Nov 2022 19:19:33 +0100
Subject: [PATCH] Full refactor to Typescript

---
 client/App.tsx                                | 33 +++++++++++++++----
 client/{api.jsx => api.tsx}                   |  4 +--
 client/components/{Header.jsx => Header.tsx}  | 16 ++++++---
 .../components/{Markdown.jsx => Markdown.tsx} | 16 +++++----
 ...{MarkdownEditor.jsx => MarkdownEditor.tsx} | 20 +++++++----
 .../components/{Problem.jsx => Problem.tsx}   | 12 +++++--
 client/components/Select.jsx                  | 12 -------
 client/components/Select.tsx                  | 23 +++++++++++++
 .../components/{Solution.jsx => Solution.tsx} | 22 ++++++++-----
 client/entry-client.tsx                       |  2 +-
 client/entry-server.tsx                       |  3 +-
 client/hooks.tsx                              | 31 ++++++++++++-----
 client/pages/Admin.tsx                        | 12 +++----
 client/pages/Home.tsx                         | 11 ++++---
 client/pages/Login.tsx                        |  4 ++-
 client/pages/Problem.tsx                      | 27 +++++++++------
 client/pages/Profile.tsx                      | 18 +++++-----
 server/db/database.ts                         |  8 +++--
 shared/model.ts                               |  3 +-
 19 files changed, 181 insertions(+), 96 deletions(-)
 rename client/{api.jsx => api.tsx} (85%)
 rename client/components/{Header.jsx => Header.tsx} (77%)
 rename client/components/{Markdown.jsx => Markdown.tsx} (73%)
 rename client/components/{MarkdownEditor.jsx => MarkdownEditor.tsx} (72%)
 rename client/components/{Problem.jsx => Problem.tsx} (68%)
 delete mode 100644 client/components/Select.jsx
 create mode 100644 client/components/Select.tsx
 rename client/components/{Solution.jsx => Solution.tsx} (50%)

diff --git a/client/App.tsx b/client/App.tsx
index 28dace6..2d67f83 100644
--- a/client/App.tsx
+++ b/client/App.tsx
@@ -8,7 +8,7 @@ import { LoginPage } from './pages/Login'
 import { ProblemPage } from './pages/Problem'
 import { ProfilePage } from './pages/Profile'
 
-const Redirect = ({ to }: { default: boolean; to: string }) => {
+const Redirect = ({ to }: { to: string }) => {
     useEffect(() => {
         route(to, true)
     }, [])
@@ -23,12 +23,31 @@ const Redirect = ({ to }: { default: boolean; to: string }) => {
 export const App = ({ url }: { url?: string }) => {
     return (
         <Router url={url}>
-            <HomePage path="/" />
-            <LoginPage path="/login" />
-            <ProfilePage path="/profile" />
-            <ProblemPage path="/problem/:id" />
-            <AdminPage path="/admin" />
-            <Redirect default to="/" />
+            <HomePage
+                // @ts-ignore
+                path="/"
+            />
+            <LoginPage
+                // @ts-ignore
+                path="/login"
+            />
+            <ProfilePage
+                // @ts-ignore
+                path="/profile"
+            />
+            <ProblemPage
+                // @ts-ignore
+                path="/problem/:id"
+            />
+            <AdminPage
+                // @ts-ignore
+                path="/admin"
+            />
+            <Redirect
+                // @ts-ignore
+                default
+                to="/"
+            />
         </Router>
     )
 }
diff --git a/client/api.jsx b/client/api.tsx
similarity index 85%
rename from client/api.jsx
rename to client/api.tsx
index b2e3135..dfb264a 100644
--- a/client/api.jsx
+++ b/client/api.tsx
@@ -1,9 +1,9 @@
 export const server = {
-    async get(url) {
+    async get(url: string) {
         const res = await fetch(url, { credentials: 'include' })
         return await res.json()
     },
-    async post(url, body) {
+    async post<T>(url: string, body?: T) {
         const res = await fetch(url, {
             method: 'POST',
             credentials: 'include',
diff --git a/client/components/Header.jsx b/client/components/Header.tsx
similarity index 77%
rename from client/components/Header.jsx
rename to client/components/Header.tsx
index bd08868..238ad30 100644
--- a/client/components/Header.jsx
+++ b/client/components/Header.tsx
@@ -1,12 +1,18 @@
 import { Link } from 'preact-router/match'
-import { isAdministrator, USER_ROLE_ADMIN, USER_ROLE_MODERATOR } from '../../shared/constants.js'
+import { isAdministrator, User, UserRole } from '../../shared/model'
 
-const ROLE_LABEL = {
-    [USER_ROLE_ADMIN]: 'Admin',
-    [USER_ROLE_MODERATOR]: 'Moderatore',
+const ROLE_LABEL: Record<UserRole, string> = {
+    ['admin']: 'Admin',
+    ['moderator']: 'Moderatore',
+    ['student']: 'Studente',
 }
 
-export const Header = ({ user, noLogin }) => (
+type Props = {
+    user?: User | null
+    noLogin?: boolean
+}
+
+export const Header = ({ user, noLogin }: Props) => (
     <header>
         <div class="logo">
             <a href="/">PHC / Problemi</a>
diff --git a/client/components/Markdown.jsx b/client/components/Markdown.tsx
similarity index 73%
rename from client/components/Markdown.jsx
rename to client/components/Markdown.tsx
index e79250f..27a4fac 100644
--- a/client/components/Markdown.jsx
+++ b/client/components/Markdown.tsx
@@ -7,7 +7,7 @@ import remarkRehype from 'remark-rehype'
 import rehypeKatex from 'rehype-katex'
 import rehypeStringify from 'rehype-stringify'
 
-async function renderMarkdownAsync(source) {
+async function renderMarkdownAsync(source: string) {
     return await unified()
         .use(remarkParse)
         .use(remarkMath)
@@ -29,13 +29,15 @@ async function renderMarkdownAsync(source) {
 //         .processSync(source)
 // }
 
-export const Markdown = ({ source }) => {
-    const elementRef = useRef()
+export const Markdown = ({ source }: { source: string }) => {
+    const elementRef = useRef<HTMLDivElement>(null)
 
-    useEffect(async () => {
-        if (elementRef.current) {
-            elementRef.current.innerHTML = await renderMarkdownAsync(source)
-        }
+    useEffect(() => {
+        renderMarkdownAsync(source).then(data => {
+            if (elementRef.current) {
+                elementRef.current.innerHTML = data.toString()
+            }
+        })
     }, [source])
 
     return <div class="markdown" ref={elementRef}></div>
diff --git a/client/components/MarkdownEditor.jsx b/client/components/MarkdownEditor.tsx
similarity index 72%
rename from client/components/MarkdownEditor.jsx
rename to client/components/MarkdownEditor.tsx
index bcf86f9..0fc1e24 100644
--- a/client/components/MarkdownEditor.jsx
+++ b/client/components/MarkdownEditor.tsx
@@ -1,8 +1,14 @@
-import { useEffect, useRef } from 'preact/hooks'
-import { Markdown } from './Markdown.jsx'
+import { Component, JSX } from 'preact'
+import { StateUpdater, useEffect, useRef } from 'preact/hooks'
+import { Markdown } from './Markdown'
 
-export const MarkdownEditor = ({ source, setSource }) => {
-    const editorRef = useRef()
+type Props = {
+    source: string
+    setSource: StateUpdater<string>
+}
+
+export const MarkdownEditor = ({ source, setSource }: Props) => {
+    const editorRef = useRef<HTMLTextAreaElement>(null)
 
     useEffect(() => {
         if (editorRef.current) {
@@ -22,9 +28,11 @@ export const MarkdownEditor = ({ source, setSource }) => {
             <div class="editor">
                 <h1>Editor</h1>
                 <textarea
-                    onInput={e => setSource(e.target.value)}
+                    onInput={e =>
+                        setSource(e.target instanceof HTMLTextAreaElement ? e.target.value : '')
+                    }
                     value={source}
-                    cols="60"
+                    cols={60}
                     ref={editorRef}
                     placeholder="Scrivi una nuova soluzione..."
                 ></textarea>
diff --git a/client/components/Problem.jsx b/client/components/Problem.tsx
similarity index 68%
rename from client/components/Problem.jsx
rename to client/components/Problem.tsx
index 234b352..a048a8b 100644
--- a/client/components/Problem.jsx
+++ b/client/components/Problem.tsx
@@ -1,6 +1,12 @@
-import { Markdown } from './Markdown.jsx'
+import { Markdown } from './Markdown'
 
-export const Problem = ({ id, content, solutionsCount }) => {
+type Props = {
+    id: string
+    content: string
+    solutionsCount?: number
+}
+
+export const Problem = ({ id, content, solutionsCount }: Props) => {
     return (
         <div class="problem">
             <div class="problem-header">
@@ -11,7 +17,7 @@ export const Problem = ({ id, content, solutionsCount }) => {
             <div class="problem-content">
                 <Markdown source={content} />
             </div>
-            {solutionsCount > 0 && (
+            {solutionsCount && solutionsCount > 0 && (
                 <div class="problem-footer">
                     {solutionsCount} soluzion{solutionsCount === 1 ? 'e' : 'i'}
                 </div>
diff --git a/client/components/Select.jsx b/client/components/Select.jsx
deleted file mode 100644
index 0315c2c..0000000
--- a/client/components/Select.jsx
+++ /dev/null
@@ -1,12 +0,0 @@
-export const Select = ({ options, value, setValue }) => (
-    <div class="input-select">
-        <select onInput={e => setValue?.(e.target.value)}>
-            {Object.entries(options).map(([k, v]) => (
-                <option value={k} selected={value === k}>
-                    {v}
-                </option>
-            ))}
-        </select>
-        <span class="material-symbols-outlined">expand_more</span>
-    </div>
-)
diff --git a/client/components/Select.tsx b/client/components/Select.tsx
new file mode 100644
index 0000000..39e2045
--- /dev/null
+++ b/client/components/Select.tsx
@@ -0,0 +1,23 @@
+import { StateUpdater } from 'preact/hooks'
+import { JSX } from 'preact/jsx-runtime'
+
+type Props = {
+    options: Record<string, string>
+    value: string
+    setValue?: StateUpdater<string>
+}
+
+export const Select = ({ options, value, setValue }: Props) => (
+    <div class="input-select">
+        <select
+            onInput={e => setValue?.(e.target instanceof HTMLSelectElement ? e.target.value : '')}
+        >
+            {Object.entries(options).map(([k, v]) => (
+                <option value={k} selected={value === k}>
+                    {v}
+                </option>
+            ))}
+        </select>
+        <span class="material-symbols-outlined">expand_more</span>
+    </div>
+)
diff --git a/client/components/Solution.jsx b/client/components/Solution.tsx
similarity index 50%
rename from client/components/Solution.jsx
rename to client/components/Solution.tsx
index 112d7d2..22a88e8 100644
--- a/client/components/Solution.jsx
+++ b/client/components/Solution.tsx
@@ -1,25 +1,29 @@
-import { refToUserId } from '../../shared/db-refs.js'
-import { Markdown } from './Markdown.jsx'
+import { ProblemId, SolutionStatus, UserId } from '../../shared/model'
+import { Markdown } from './Markdown'
 
-export const Solution = ({ sentBy, forProblem, content }) => {
-    const userId = refToUserId(sentBy)
-    const problemId = refToUserId(forProblem)
+type Props = {
+    sentBy?: UserId
+    forProblem: ProblemId
+    content: string
+    status?: SolutionStatus
+}
 
+export const Solution = ({ sentBy, forProblem, content }: Props) => {
     return (
         <div class="solution">
             <div class="solution-header">
                 <div>
                     Soluzione
-                    {userId && (
+                    {sentBy && (
                         <>
                             {' '}
-                            di <a href={`/user/${userId}`}>@{userId}</a>
+                            di <a href={`/user/${sentBy}`}>@{sentBy}</a>
                         </>
                     )}
-                    {problemId && (
+                    {forProblem && (
                         <>
                             {' '}
-                            per il <a href={`/problem/${problemId}`}>Problema {problemId}</a>
+                            per il <a href={`/problem/${forProblem}`}>Problema {forProblem}</a>
                         </>
                     )}
                 </div>
diff --git a/client/entry-client.tsx b/client/entry-client.tsx
index fb04c7a..fbaba39 100644
--- a/client/entry-client.tsx
+++ b/client/entry-client.tsx
@@ -1,4 +1,4 @@
 import { hydrate } from 'preact'
 import { App } from './App'
 
-// hydrate(<App />, document.body)
+hydrate(<App />, document.body)
diff --git a/client/entry-server.tsx b/client/entry-server.tsx
index 1170d3b..714d951 100644
--- a/client/entry-server.tsx
+++ b/client/entry-server.tsx
@@ -3,13 +3,14 @@ import renderToString from 'preact-render-to-string'
 import { MetadataContext } from './hooks'
 
 import { RenderedPage } from '../shared/ssr'
+import { App } from './App'
 
 export default (url: string): RenderedPage => {
     const metadata = {}
 
     const html = renderToString(
         <MetadataContext.Provider value={metadata}>
-            {/* <App url={url} /> */}
+            <App url={url} />
         </MetadataContext.Provider>
     )
 
diff --git a/client/hooks.tsx b/client/hooks.tsx
index 65880a3..f987f65 100644
--- a/client/hooks.tsx
+++ b/client/hooks.tsx
@@ -1,11 +1,20 @@
 import { useEffect, useState } from 'preact/hooks'
 
 import { createContext } from 'preact'
-import { server } from './api.jsx'
+import { server } from './api'
+import { User } from '../shared/model'
 
-export const MetadataContext = createContext({})
+type Metadata = {
+    title?: string
+}
+
+export const MetadataContext = createContext<Metadata>({})
+
+type CurrentUserHook = (
+    onLoaded?: (user: User | null) => void
+) => [User | null, () => Promise<void>]
 
-export const useCurrentUser = onLoaded => {
+export const useCurrentUser: CurrentUserHook = onLoaded => {
     const [user, setUser] = useState(null)
 
     const logout = async () => {
@@ -13,16 +22,22 @@ export const useCurrentUser = onLoaded => {
         setUser(null)
     }
 
-    useEffect(async () => {
-        const user = await server.get('/api/current-user')
-        setUser(user)
-        onLoaded?.(user)
+    useEffect(() => {
+        server.get('/api/current-user').then(user => {
+            setUser(user)
+            onLoaded?.(user)
+        })
     }, [])
 
     return [user, logout]
 }
 
-export const useReadResource = (url, initialValue) => {
+type ReadResourceFunction = <T>(
+    url: string | (() => string),
+    initialValue: T
+) => [T, () => AbortController]
+
+export const useReadResource: ReadResourceFunction = (url, initialValue) => {
     const [value, setValue] = useState(initialValue)
 
     function refresh() {
diff --git a/client/pages/Admin.tsx b/client/pages/Admin.tsx
index 1c93fbb..a8522fb 100644
--- a/client/pages/Admin.tsx
+++ b/client/pages/Admin.tsx
@@ -1,10 +1,10 @@
 import { route } from 'preact-router'
-import { useEffect, useState } from 'preact/hooks'
-import { isAdministrator, isStudent } from '../../shared/constants.js'
-import { server } from '../api.jsx'
-import { Header } from '../components/Header.jsx'
-import { MarkdownEditor } from '../components/MarkdownEditor.jsx'
-import { useCurrentUser } from '../hooks.jsx'
+import { useState } from 'preact/hooks'
+import { isStudent } from '../../shared/model'
+import { server } from '../api'
+import { Header } from '../components/Header'
+import { MarkdownEditor } from '../components/MarkdownEditor'
+import { useCurrentUser } from '../hooks'
 
 const CreateProblem = ({}) => {
     const [source, setSource] = useState('')
diff --git a/client/pages/Home.tsx b/client/pages/Home.tsx
index 049f666..d031933 100644
--- a/client/pages/Home.tsx
+++ b/client/pages/Home.tsx
@@ -1,14 +1,15 @@
 import { route } from 'preact-router'
 import { useEffect, useState } from 'preact/hooks'
-import { Header } from '../components/Header.jsx'
+import { Problem as ProblemModel } from '../../shared/model'
+import { Header } from '../components/Header'
 
-import { Problem } from '../components/Problem.jsx'
-import { Select } from '../components/Select.jsx'
-import { useReadResource, useCurrentUser } from '../hooks.jsx'
+import { Problem } from '../components/Problem'
+import { Select } from '../components/Select'
+import { useReadResource, useCurrentUser } from '../hooks'
 
 export const HomePage = () => {
     const [user] = useCurrentUser()
-    const [problems] = useReadResource('/api/problems', [])
+    const [problems] = useReadResource<ProblemModel[]>('/api/problems', [])
 
     console.log(problems)
 
diff --git a/client/pages/Login.tsx b/client/pages/Login.tsx
index b1e084b..8870105 100644
--- a/client/pages/Login.tsx
+++ b/client/pages/Login.tsx
@@ -30,7 +30,9 @@ export const LoginPage = () => {
                     id="login-username"
                     type="text"
                     value={username}
-                    onInput={e => setUsername(e.target.value)}
+                    onInput={e =>
+                        setUsername(e.target instanceof HTMLInputElement ? e.target.value : '')
+                    }
                     onKeyDown={e => e.key === 'Enter' && login()}
                 />
 
diff --git a/client/pages/Problem.tsx b/client/pages/Problem.tsx
index 43adbd5..58bd795 100644
--- a/client/pages/Problem.tsx
+++ b/client/pages/Problem.tsx
@@ -1,12 +1,17 @@
 import { useContext, useEffect, useRef, useState } from 'preact/hooks'
-import { server } from '../api.jsx'
-import { Header } from '../components/Header.jsx'
-import { MarkdownEditor } from '../components/MarkdownEditor.jsx'
-import { Problem } from '../components/Problem.jsx'
-import { Solution } from '../components/Solution.jsx'
-import { MetadataContext, useCurrentUser, useReadResource } from '../hooks.jsx'
-
-export const ProblemPage = ({ id }) => {
+import { Problem as ProblemModel, Solution as SolutionModel } from '../../shared/model'
+import { server } from '../api'
+import { Header } from '../components/Header'
+import { MarkdownEditor } from '../components/MarkdownEditor'
+import { Problem } from '../components/Problem'
+import { Solution } from '../components/Solution'
+import { MetadataContext, useCurrentUser, useReadResource } from '../hooks'
+
+type RouteProps = {
+    id: string
+}
+
+export const ProblemPage = ({ id }: RouteProps) => {
     const metadata = useContext(MetadataContext)
     metadata.title = `Problem ${id}`
 
@@ -14,9 +19,11 @@ export const ProblemPage = ({ id }) => {
 
     const [source, setSource] = useState('')
 
-    const [{ content }] = useReadResource(`/api/problem/${id}`, { content: '' })
+    const [{ content }] = useReadResource<{ content: string }>(`/api/problem/${id}`, {
+        content: '',
+    })
 
-    const [solutions] = useReadResource(`/api/solutions?problem=${id}`, [])
+    const [solutions] = useReadResource<SolutionModel[]>(`/api/solutions?problem=${id}`, [])
 
     const sendSolution = async () => {
         await server.post('/api/solution', {
diff --git a/client/pages/Profile.tsx b/client/pages/Profile.tsx
index 46e9f12..7e86a3a 100644
--- a/client/pages/Profile.tsx
+++ b/client/pages/Profile.tsx
@@ -1,19 +1,21 @@
 import { route } from 'preact-router'
 import { useState } from 'preact/hooks'
-import { server } from '../api.jsx'
-import { Header } from '../components/Header.jsx'
-import { Solution } from '../components/Solution.jsx'
-import { useCurrentUser, useReadResource } from '../hooks.jsx'
+import { server } from '../api'
+import { Header } from '../components/Header'
+import { Solution } from '../components/Solution'
+import { useCurrentUser } from '../hooks'
 
 export const ProfilePage = ({}) => {
     const [solutions, setSolutions] = useState([])
 
-    const [user, logout] = useCurrentUser(async user => {
-        if (!user) {
+    const [user, logout] = useCurrentUser(user => {
+        if (user) {
+            server.get(`/api/solutions?user=${user.id}`).then(solutions => {
+                setSolutions(solutions)
+            })
+        } else {
             route('/login', true)
         }
-
-        setSolutions(await server.get(`/api/solutions?user=${user.id}`))
     })
 
     const handleLogout = () => {
diff --git a/server/db/database.ts b/server/db/database.ts
index f55be9c..8e582d0 100644
--- a/server/db/database.ts
+++ b/server/db/database.ts
@@ -3,7 +3,7 @@ import crypto from 'crypto'
 import { readFile, writeFile, access, constants } from 'fs/promises'
 
 import {
-    CommonProps as MetaProps,
+    MetadataProps as MetaProps,
     Problem,
     ProblemId,
     Solution,
@@ -191,14 +191,16 @@ export const updateSolution = (
     })
 
 type SolutionsQuery = Partial<{
-    sentBy: UserId
-    forProblem: ProblemId
+    sentBy?: UserId
+    forProblem?: ProblemId
 }>
 
 export const getSolutions = (db: DatabaseConnection, { sentBy, forProblem }: SolutionsQuery = {}) =>
     withDatabase(db, state => {
         let solutions = Object.values(state.solutions)
 
+        console.log(solutions.length, sentBy, forProblem)
+
         if (sentBy) {
             solutions = solutions.filter(s => s.sentBy === sentBy)
         }
diff --git a/shared/model.ts b/shared/model.ts
index 7d3cd04..cb43761 100644
--- a/shared/model.ts
+++ b/shared/model.ts
@@ -2,10 +2,9 @@
 // Common
 //
 
-export type CommonProps = 'id' | 'createdAt'
+export type MetadataProps = 'id' | 'createdAt'
 
 type Opaque<T, K, L extends string = 'opaque'> = T & { _: K; __: L }
-
 type Id<T> = Opaque<string, T, 'id'>
 
 //